sql/jobs: fix races in TestRegistryResumeExpiredLease #20635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
benesch
approved these changes
Dec 11, 2017
| testutils.SucceedsSoon(t, func() error { | ||
| lock.Lock() | ||
| if e, a := 2, resumeCounts[jobMap[3]]; e != a { | ||
| defer lock.Unlock() | ||
| if e, a := 2, resumeCounts[jobMap[3]]; e > a { | ||
| return errors.Errorf("expected resumeCount to be %d, but got %d", e, a) |
There was a problem hiding this comment.
Ideally the error message would be updated a la expected hookCallCount to be > %d, but got %d.
Release note: None Sometimes jobs will resume more times than usual. Move lock and unlocking to places to prevent deadlocks. Move the done close to a place that will allow all jobs to proceed without receiving from resumeCalled. Fixes #20623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None
Sometimes jobs will resume more times than usual. Move lock and
unlocking to places to prevent deadlocks. Move the done close to
a place that will allow all jobs to proceed without receiving from
resumeCalled.
Fixes #20623